Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source: devices: AM62*: linux: Updated LPM power measurements for SDK 10.0 #17

Merged
merged 1 commit into from
Nov 8, 2024
Merged

source: devices: AM62*: linux: Updated LPM power measurements for SDK 10.0 #17

merged 1 commit into from
Nov 8, 2024

Conversation

kwillis01
Copy link
Contributor

Updated DeepSleep and MCU Only LPM power measurements in the Linux performance guide.

@kwillis01
Copy link
Contributor Author

@madweshanshu

@cshilwant
Copy link
Member

@kwillis01 What's the reason of updating SDK 10.0 power numbers now?
This eventually won't get published on software-dl.ti.com and with SDK 10.1 around the corners it might even get updated with revised numbers.

@nmenon
Copy link
Contributor

nmenon commented Oct 28, 2024

rebase on master to get the checkers to run

@kwillis01
Copy link
Contributor Author

@cshilwant Is there anyway software-dl.ti.com can be updated with the 10.0 numbers sooner. Currently SDK 9.2 power measurements is in the release notes for 10.0.

@kwillis01 kwillis01 force-pushed the power-measurements branch 3 times, most recently from e2407b1 to 56848c3 Compare October 30, 2024 16:47
@cshilwant
Copy link
Member

@kwillis01 In general, the plan was to stop SDK 10.0 documentation syncing once the SDK 10.1 RCs started. The merge window for documentation bug fixes for SDK 10.1 is now open. So, doing a documentation syncing now might lead syncing of any SDK 10.1 specific commit in SDK 10.0 docs (Will need to see if there any PRs that went in)

The suggestion would be to wait until SDK 10.1 & fix the power numbers on 10.1 baseline.

@cshilwant cshilwant requested review from nmenon, praneethbajjuri and StaticRocket and removed request for nmenon October 31, 2024 23:37
@cshilwant
Copy link
Member

@kwillis01 The permission error observed with Commit Check workflow is now fixed.
Can you rebase your PR on top of latest master?

cshilwant
cshilwant requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for PR to be rebased with master

@kwillis01 kwillis01 requested a review from cshilwant November 1, 2024 15:04
@cshilwant
Copy link
Member

@kwillis01 The workflow throws an error. Please check https://github.com/TexasInstruments/processor-sdk-doc/actions/runs/11631469679#summary-32394326587 for more details on what's needed to be fixed in commit message

Refer https://github.com/TexasInstruments/processor-sdk-doc/blob/master/CONTRIBUTING.md for more details on CONTRIBUTING guidelines

DhruvaG2000
DhruvaG2000 approved these changes Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwillis01 For commit style, see for example cf40654 . This is not the same way we do commits for linux kernel. @cshilwant has shared an useful link to contrib guide as well that you can refer to.
With that addressed, the changes in the docs look good. Thanks for fixing the am62a/dev names in the table to power/mw.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

New warnings found with rstcheck:

source/linux/Foundational_Components_Multimedia_D5520_VXE384.rst:96: (WARNING/2) Bullet list ends without a blank line; unexpected unindent.
source/linux/Release_Specific_CoreSDK_Release_Notes.rst:53: (WARNING/2) Bullet list ends without a blank line; unexpected unindent.
source/rtos/PDK_Platform_Software/IPC/_Use_Cases_for_IPC.rst:28: (WARNING/2) Explicit markup ends without a blank line; unexpected unindent.
source/rtos/PDK_Platform_Software/Boot_Board_and_EVM_Abstractions/_BOOT_K2G.rst:142: (WARNING/2) Line block ends without a blank line.

@kwillis01
docs(linux): Updated AM62* LPM power measurements for SDK 10.0
5465ef8 
Updated DeepSleep and MCU Only LPM power measurements in the Linux
performance guide for AM62X, AM62A, and AM62P.

Signed-off-by: Kendall Willis <[email protected]>
@cshilwant cshilwant merged commit 22d2639 into TexasInstruments:master Nov 8, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmenon nmenon nmenon left review comments

@cshilwant cshilwant cshilwant approved these changes

@DhruvaG2000 DhruvaG2000 DhruvaG2000 approved these changes

@praneethbajjuri praneethbajjuri praneethbajjuri approved these changes

@StaticRocket StaticRocket Awaiting requested review from StaticRocket StaticRocket is a code owner

@uditkumarti uditkumarti Awaiting requested review from uditkumarti uditkumarti is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kwillis01 @cshilwant @nmenon @praneethbajjuri @DhruvaG2000